-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Fix error when --scaled 1 is set. #156
Conversation
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
==========================================
- Coverage 85.55% 85.34% -0.22%
==========================================
Files 13 13
Lines 1828 1829 +1
Branches 52 52
==========================================
- Hits 1564 1561 -3
- Misses 255 259 +4
Partials 9 9
Continue to review full report at Codecov.
|
Ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #152 by setting
max_hash
to be 0 when--scaled=1
.Also addresses #112 by adding
MINHASH_MAX_HASH
and a getter to the extension module,and adds a module-level getter for
DEFAULT_SEED
(#96).make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?